From e0000e2479e3a62e91280faa8b9ebdfce2083d8d Mon Sep 17 00:00:00 2001
From: Thomas Ruoff <ThomasRuoff@gmail.com>
Date: Wed, 27 Jan 2021 23:53:37 +0100
Subject: [PATCH] fix a few issues

---
 run.sh | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/run.sh b/run.sh
index 1d6c929..7431832 100755
--- a/run.sh
+++ b/run.sh
@@ -2,9 +2,6 @@
 
 set -o errexit -o nounset
 
-# as suggested in https://github.com/koalaman/shellcheck/wiki/SC2044
-shopt -s globstar nullglob
-
 OCRMYPDF_CMD='docker run --rm -i ocrmypdf'
 
 SCR_DIR=/mnt/docscans
@@ -31,7 +28,7 @@ function ocrFile() {
     --rotate-pages             \
     --deskew                   \
     - -                        \
-    < "$FILE"                  \
+    < "$SRC"                   \
     > "$DST_PDF" 2> "$DST_LOG"
 }
 
@@ -41,25 +38,31 @@ flock -n 100 || { echo $LOCKFILE is locked; exit 1; }
 
 mkdir -p "$DST_DIR" "$ARCHIVE_DIR" "$FAILED_DIR" "$LOG_DIR"
 
-while IFS= read -r -d '' file
+while IFS= read -r -d '' FILE
 do
   echo "processing $FILE ..."
 
-  if ocrFile "$FILE" "$DST_DIR"
+  if ocrFile "$FILE"
   then
     echo processed "$FILE"
     mv "$FILE" "$ARCHIVE_DIR"
     echo moved "$FILE" to "$ARCHIVE_DIR"
-    (( PROCESSED_COUNT++ ))
+    (( PROCESSED_COUNT+=1 ))
   else
     echo failed to process "$FILE"
     mv "$FILE" "$FAILED_DIR"
     echo moved "$FILE" to "$FAILED_DIR"
-    (( FAILED_COUNT++ ))
+    (( FAILED_COUNT+=1 ))
   fi
+  echo
 done <   <(find $SCR_DIR -maxdepth 1 -name '*.pdf' -print0)
 
 echo Done
-echo processed $PROCESSED_COUNT PDFs
-[ $FAILED_COUNT -gt 0 ] && echo failed on $FAILED_COUNT PDFs
+echo
+echo processed "$PROCESSED_COUNT" PDFs
+
+if (( FAILED_COUNT > 0 ))
+then
+  echo failed on "$FAILED_COUNT" PDFs
+fi