add a proper login page

This commit is contained in:
Thomas Ruoff
2020-11-04 00:14:29 +01:00
parent b283ffe476
commit 1dfd1f1f8b
6 changed files with 163 additions and 38 deletions

View File

@@ -1,28 +1,18 @@
import { IncomingMessage, ServerResponse } from 'http' export function authenticateAdmin({
username,
export default function authenticate( password,
req: IncomingMessage, }: {
res: ServerResponse username: string
) { password: string
const authHeader = req.headers.authorization }) {
if (username !== 'admin') {
if (!authHeader) { return false
res.setHeader('WWW-Authenticate', 'Basic')
res.statusCode = 401
return null
} }
const [username, password] = Buffer.from(authHeader.split(' ')[1], 'base64') // FIXME: move at least to env variable
.toString() if (password !== 'secret') {
.split(':') return false
// FIXME: pull admin password from env
if (username === 'admin' || password === 'secret') {
return { username: 'admin', role: 'admin' }
} }
res.setHeader('WWW-Authenticate', 'Basic') return true
res.statusCode = 401
res.end()
return null
} }

View File

@@ -1,4 +1,5 @@
import { withIronSession, Handler } from 'next-iron-session' import { withIronSession, Handler } from 'next-iron-session'
import { getBaseURL } from '../helpers/url'
const SESSION_SECRET = const SESSION_SECRET =
process.env.SESSION_SECRET || 'dev-env-default-secret-991823723' process.env.SESSION_SECRET || 'dev-env-default-secret-991823723'
@@ -19,8 +20,17 @@ export default function withSession(handler: Handler) {
export const isAdminSession = function (req: any, res: any) { export const isAdminSession = function (req: any, res: any) {
const user = req?.session.get('user') const user = req?.session.get('user')
if (user && user.role === 'admin') { if (user && user.role === 'admin') {
return true return user
} }
res.status(401).end('Your are unauthorized. Best to move along...')
const redirectTargetUrl = `${getBaseURL()}/admin/login?redirect=${encodeURIComponent(
req.url
)}`
res.writeHead(303, {
Location: redirectTargetUrl,
})
res.end()
return false return false
} }

View File

@@ -1,5 +1,5 @@
import { GetServerSideProps } from 'next'
import React, { useEffect, useState } from 'react' import React, { useEffect, useState } from 'react'
import { GetServerSideProps } from 'next'
import Footer from '../../../../components/footer' import Footer from '../../../../components/footer'
import Header from '../../../../components/header' import Header from '../../../../components/header'
import Input from '../../../../components/input' import Input from '../../../../components/input'
@@ -11,31 +11,26 @@ import { getMilageMax } from '../../../../db/index'
import { dateFormatFrontend } from '../../../../helpers/date' import { dateFormatFrontend } from '../../../../helpers/date'
import { getBillTotal } from '../../../../helpers/bill' import { getBillTotal } from '../../../../helpers/bill'
import { getBookingStatus } from '../../../../helpers/booking' import { getBookingStatus } from '../../../../helpers/booking'
import authenticate from '../../../../lib/authenticate' import withSession, { isAdminSession } from '../../../../lib/session'
import withSession from '../../../../lib/session'
import { getServerSideBooking } from '../../../../lib/getServerSideProps' import { getServerSideBooking } from '../../../../lib/getServerSideProps'
export const getServerSideProps: GetServerSideProps = withSession( export const getServerSideProps: GetServerSideProps = withSession(
async (context) => { async (context) => {
const { req, res } = context const { req, res } = context
const authenticatedUser = authenticate(req, res) const adminUser = isAdminSession(req, res)
if (!authenticatedUser) {
// TODO: not sure if needed if (!adminUser) {
req?.session.destroy()
return { props: {} } return { props: {} }
} }
req.session.set('user', authenticatedUser)
await req.session.save()
const milageMax = await getMilageMax() const milageMax = await getMilageMax()
const result = await getServerSideBooking(context) const result = await getServerSideBooking(context)
return { return {
...result, ...result,
// TODO: have a closer look at this type issue. Seems like a bug // TODO: have a closer look at this type issue. Seems like a bug
// @ts-ignore // @ts-ignore
props: { ...result.props, milageMax }, props: { ...result.props, milageMax, user: adminUser },
} }
} }
) )
@@ -107,7 +102,7 @@ async function saveBill(
return response.json() return response.json()
} }
export default function BillPage({ export default function BookingBillPage({
booking: bookingProp, booking: bookingProp,
milageMax, milageMax,
}: { }: {

View File

@@ -1,14 +1,35 @@
import React, { useEffect, useState } from 'react' import React, { useEffect, useState } from 'react'
import { GetServerSideProps } from 'next'
import Footer from '../../../../components/footer' import Footer from '../../../../components/footer'
import Header from '../../../../components/header' import Header from '../../../../components/header'
import Calendar from '../../../../components/calendar' import Calendar from '../../../../components/calendar'
import withSession, { isAdminSession } from '../../../../lib/session'
import { getServerSideBooking } from '../../../../lib/getServerSideProps' import { getServerSideBooking } from '../../../../lib/getServerSideProps'
import { BookingDocument } from '../../../../db/booking' import { BookingDocument } from '../../../../db/booking'
import { getBookingStatus } from '../../../../helpers/booking' import { getBookingStatus } from '../../../../helpers/booking'
import { dateFormatFrontend } from '../../../../helpers/date' import { dateFormatFrontend } from '../../../../helpers/date'
import { BOOKING_STATUS } from '../../../../db/enums' import { BOOKING_STATUS } from '../../../../db/enums'
export const getServerSideProps = getServerSideBooking export const getServerSideProps: GetServerSideProps = withSession(
async (context) => {
const { req, res } = context
console.error('here')
const adminUser = isAdminSession(req, res)
if (!adminUser) {
return { props: {} }
}
const result = await getServerSideBooking(context)
return {
...result,
// TODO: have a closer look at this type issue. Seems like a bug
// @ts-ignore
props: { ...result.props, user: adminUser },
}
}
)
async function patchBooking(uuid: string, bookingData: any) { async function patchBooking(uuid: string, bookingData: any) {
const response = await fetch(`/api/admin/booking/${uuid}`, { const response = await fetch(`/api/admin/booking/${uuid}`, {

82
pages/admin/login.tsx Normal file
View File

@@ -0,0 +1,82 @@
import React, { useState } from 'react'
import { useRouter } from 'next/router'
import Head from 'next/head'
import Footer from '../../components/footer'
import Header from '../../components/header'
import Input from '../../components/input'
import { getBaseURL } from '../../helpers/url'
export default function Home() {
const router = useRouter()
const [username, setUsername] = useState('')
const [password, setPassword] = useState('')
const isValid = !!username.length && !!password.length
async function onSubmit(event: React.FormEvent<HTMLFormElement>) {
event.preventDefault()
try {
await fetch('/api/admin/login', {
method: 'POST',
headers: {
'Content-Type': 'application/json',
},
body: JSON.stringify({
username,
password,
}),
}).then((response) => {
if (!response.ok) {
console.error('Unable to login', response.status, response.statusText)
return
}
const redirect = Array.isArray(router.query?.redirect)
? router.query.redirect[0]
: router.query?.redirect
router.push(redirect || getBaseURL())
})
} catch (error) {
console.error('Unable to login', error)
}
}
return (
<>
<Head>
<title>Pfadi Bussle Admin</title>
<link rel="icon" href="/favicon.ico" />
</Head>
<Header label="Pfadi Bussle Admin Login" />
<main className="main w-64">
<form className="form" onSubmit={onSubmit}>
<Input
label="Username"
name="username"
onChange={(event: React.ChangeEvent<HTMLInputElement>) =>
setUsername(event.target.value)
}
/>
<Input
label="Password"
name="password"
type="password"
onChange={(event: React.ChangeEvent<HTMLInputElement>) =>
setPassword(event.target.value)
}
/>
<button
type="submit"
className="btn btn-blue ml-0"
disabled={!isValid}
>
Login
</button>
</form>
</main>
<Footer />
</>
)
}

27
pages/api/admin/login.ts Normal file
View File

@@ -0,0 +1,27 @@
import { authenticateAdmin } from '../../../lib/authenticate'
import withSession from '../../../lib/session'
async function loginHandler(req: any, res: any) {
const { method } = req
switch (method) {
case 'POST':
const { username, password } = req.body
if (!authenticateAdmin({ username, password })) {
res.status(401).end()
return
}
const userData = { username, role: 'admin' }
req.session.set('user', userData)
await req.session.save()
res.json({ message: 'Authenticated', user: userData })
break
default:
res.setHeader('Allow', ['POST'])
res.status(405).end(`Method ${method} Not Allowed`)
}
}
export default withSession(loginHandler)